-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11219 adapt UI font size #12042
base: main
Are you sure you want to change the base?
11219 adapt UI font size #12042
Conversation
then remove the unused css files as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete the unused css files and check if they are referenced somehwere
@@ -0,0 +1,1736 @@ | |||
.root { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You really don't have to create backup files, this is what git is for.
Hi, I have deleted original individual CSS files and the BaseBackUp.css and consolidated styles into Base.css. |
@@ -3,7 +3,7 @@ title: "Developer Documentation" | |||
remote_theme: just-the-docs/[email protected] | |||
color_scheme: light | |||
|
|||
exclude: [_config.yml, .dockerignore, .gitignore, CNAME, Dockerfile, Gemfile, Gemfile.lock, README.md, mkdocs-custom.css] | |||
exclude: [_config.yml, .dockerignore, .gitignore, CNAME, Dockerfile, Gemfile, Gemfile.lock, README.md] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Even if this affects our documentation, I think, this removal is OK.
@@ -117,7 +117,7 @@ public GroupTreeView(TaskExecutor taskExecutor, | |||
this.aiService = aiService; | |||
|
|||
createNodes(); | |||
this.getStylesheets().add(Objects.requireNonNull(GroupTreeView.class.getResource("GroupTree.css")).toExternalForm()); | |||
this.getStylesheets().add(Objects.requireNonNull(GroupTreeView.class.getResource("/org/jabref/gui/Base.css")).toExternalForm()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is even necessary, the Base.cs stylesheet is applied globally, so it would be automatically applied to all nodes in the hierarchy. However, you probably need to add custom classes for the group tree etc to prevent side effects with other elements
see my PR for an example
#11881
closes #11219
Merged all the CSS files to Base.css
converted all px units to em
Fixed toggle button and sperator padding issue
Conducted UI testing by comparing interfaces before and after changes.
Mandatory checks
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)